On Fri, 5 Feb 2021 12:03:30 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Could I get the following change reviewed please? It fixes a problem (in >> JEP380) on Windows where some file operations on Unix domain sockets were >> not working and led to the feature being disabled on Windows 2019 Server in >> JDK 16. So, the fix re-enables the feature on all versions of Windows that >> support it. >> >> The test checks all the file APIs that were affected by the problem. The >> change touches the code that handles symbolic links in Windows (since they >> are implemented as NTFS reparse points, like Unix sockets), but I didn't add >> any specific testing in this area, as I assume the existing unit tests for >> NIO symbolic links should cover that. If I should add more tests here, then >> I can do that. >> >> Thanks, >> Michael > > test/jdk/java/nio/channels/unixdomain/FileAttributes.java line 82: > >> 80: >> 81: // Check deletion >> 82: assertTrue(f.delete(), "File.delete failed"); > > What happens to the socket if you delete the file before closing the socket? > Isn't that going to cause trouble? Deleting the file prevents new connections from being accepted, but doesn't cause any problems for the channel itself. Since the test is finished at that point I don't think there is a problem. ------------- PR: https://git.openjdk.java.net/jdk/pull/2424
