On Tue, 9 Feb 2021 08:30:54 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Hello, >> Currently in jdk/internal/vm/VMSupport.java , we create a JarFile without a >> related finally clause or try with resources. That should better be changed. >> See also the Sonar check result : >> >> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=java&open=AXcqM8zf8sPJZZzON5qG&resolved=false&severities=BLOCKER&types=BUG >> >> public static boolean isClassPathAttributePresent(String path) { >> try { >> Manifest man = (new JarFile(path)).getManifest(); >> Use try-with-resources or close this "JarFile" in a "finally" clause. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Remove isClassPathAttributePresent Removing it looks fine. Can you change the description of JDK-8261237 to reflect the change. ------------- Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2429
