On Tue, 9 Feb 2021 15:58:36 GMT, Andy Herrick <[email protected]> wrote:
>> SonarCloud instance reports a new warning after JDK-8254702:
>> "Use of memory after it is freed"
>>
>> char* getJvmLauncherLibPath(void) {
>> ...
>> popenStatus = popenCommand(pkgQueryCmd, pkg->name, findLauncherLib,
>> &launcherLibPath);
>> if (popenStatus) {
>> free(launcherLibPath); <---- frees here
>> goto cleanup;
>> }
>> }
>>
>> cleanup:
>> free(modulePath);
>> freePackageDesc(pkg);
>>
>> return launcherLibPath; <--- here
>> }
>>
>> We need to null it out before returning.
>>
>> Additional testing:
>> - [x] Linux x86_64 (Ubuntu) `tools/jpackage`
>
> Marked as reviewed by herrick (Reviewer).
Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/2453
