On Mon, 8 Feb 2021 08:49:17 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

> SonarCloud instance reports as new warning after JDK-8254702:
> 
> This branch can not be reached because the condition duplicates a previous 
> condition in the same sequence of "if/else if" statements.
> 
> char* getJvmLauncherLibPath(void) {
>    ...
>         if (PACKAGE_TYPE_RPM == pkg->type) {
>             pkgQueryCmd = "rpm -ql '%s' 2>/dev/null";
>         } else if (PACKAGE_TYPE_RPM == pkg->type) { <--- here
>             pkgQueryCmd = "dpkg -L '%s' 2>/dev/null";
> 
> Seems like an obvious typo.
> 
> Additional tests:
>  - [x] Linux x86_64 (Ubuntu) `tools/jpackage`

This pull request has now been integrated.

Changeset: a7726390
Author:    Aleksey Shipilev <sh...@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/a7726390
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo

Reviewed-by: asemenyuk, almatvee, herrick

-------------

PR: https://git.openjdk.java.net/jdk/pull/2452

Reply via email to