On Fri, 12 Feb 2021 11:02:36 GMT, Christoph Langer <clan...@openjdk.org> wrote:

>> JDK-8261422: Adjust problematic String.format calls in 
>> jdk/internal/util/Preconditions.java outOfBoundsMessage
>
> As we're potentially formatting any "Number" type here, theoretically floats 
> could be passed which would result in an Exception. In fact, only decimal 
> types are passed by the callers so this should not happen. Unfortunately 
> there's no super type specifying decimal numbers.
> 
> And as we're not doing some fancy formatting but just %d, I think replacing 
> this with %s should be ok.

I see this change been integrated but there is further work required on the 
test coverage. Are you planing to do code coverage and create a follow-on issue 
to add more tests?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2483

Reply via email to