Hi Vicente, thanks for the review. May I ask you also to /sponsor this PR?
Thanks again, Adam On 25/02/2021, 16:39, "core-libs-dev on behalf of Vicente Romero" <core-libs-dev-r...@openjdk.java.net on behalf of vrom...@openjdk.java.net> wrote: On Thu, 25 Feb 2021 13:01:30 GMT, Adam Sotona <asot...@openjdk.org> wrote: > Please review javap fix to handle java.lang.IllegalStateException for classes with invalid Signature attribute. > New test (T8260403) parsing class with invalid Signature attribute (as described in the bug) is included. > Fix wraps java.lang.IllegalStateException, reports "Error: Invalid value for Signature attribute: <signature debug info>" and continues. > > Thanks, > Adam lgtm! ------------- Marked as reviewed by vromero (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2724