On Tue, 2 Mar 2021 15:05:51 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year. > > src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 579: > >> 577: /** >> 578: * A soft maximum array length imposed by array growth computations. >> 579: * Some JVMs (such as Hotspot) have an implementation limit that >> will cause > > The numbers of spellings "HotSpot" to that of "Hotspot" in the JDK codebase > is 10 to 1 respectively. Also, on my machine I can see this: > > $ java --version > java 15 2020-09-15 > Java(TM) SE Runtime Environment (build 15+36-1562) > Java HotSpot(TM) 64-Bit Server VM (build 15+36-1562, mixed mode, sharing) Fixed. > test/jdk/jdk/internal/util/ArraysSupport/NewLength.java line 100: > >> 98: int r = ArraysSupport.newLength(old, min, pref); >> 99: fail("expected OutOfMemoryError, got normal return value of >> " + r); >> 100: } catch (OutOfMemoryError success) { } > > Consider using `expectThrows` or `assertThrows` from `org.testng.Assert`. Good point. However, I actually tried to use assertThrows, but there doesn't seem to be a way to get the unexpected return value into the error message. I think having this value in the test output is important for diagnosing failures. ------------- PR: https://git.openjdk.java.net/jdk/pull/1617