On Fri, 5 Mar 2021 23:35:46 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Craig Andrews has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> JDK-8262277: java.net.URLClassLoader.getResource throws undocumented >> IllegalArgumentException > > test/jdk/java/net/URLClassLoader/FindResourceDoesNotThrowException.java line > 27: > >> 25: * @test >> 26: * @bug 8262277 >> 27: * @summary Test to see if URLClassLoader.getResource and >> URLClassLoader.getResources > > The summary mentions the get* methods, but the test calls the find* methods. > I think it would be good to test all four methods (getResource, getResources, > findResource, findResources), and update the summary e.g. "Test if > URLClassLoader throws IllegalArgumentException when getting or finding > resources." Good point - thank you. I've made the change and updated this PR accordingly. ------------- PR: https://git.openjdk.java.net/jdk/pull/2662
