On Sat, 13 Mar 2021 00:51:19 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> 8263536: Add missing @compile tags to jpackage tests
>
> Alexey Semenyuk has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains one commit:
> 
>   8263536: Add missing @compile tags to jpackage tests

Changes requested by iklam (Reviewer).

test/jdk/tools/jpackage/windows/WinDirChooserTest.java line 44:

> 42:  * @requires (os.family == "windows")
> 43:  * @modules jdk.jpackage/jdk.jpackage.internal
> 44:  * @compile WinDirChooserTest.java

Changes like this one is not necessary. `@run` will build WinDirChooserTest 
automatically.

`@compile` should be added only when necessary, like WinInstallerUiTest.java

-------------

PR: https://git.openjdk.java.net/jdk/pull/2975

Reply via email to