On Mon, 15 Mar 2021 20:54:54 GMT, Claes Redestad <redes...@openjdk.org> wrote:

>> Сергей Цыпанов has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains three additional 
>> commits since the last revision:
>> 
>>  - 8148937: (str) Use StringBuilder as cl4es suggests
>>  - 8148937: (str) Check also delimiter, prefix and suffix
>>  - 8148937: (str) Adapt StringJoiner for Compact Strings
>
> The copyright year and description of the microbenchmark needs to be updated 
> (my copy-paste error). I'd also consider narrowing down the parameter 
> combinations and iteration times so that default execution times is more 
> reasonable (currently ~45 minutes even though these micros stabilize in 
> seconds)

Done. I've removed mixed mode from benchmark, anyway it falls back to 
non-latin1 case

-------------

PR: https://git.openjdk.java.net/jdk/pull/2627

Reply via email to