On Sun, 14 Mar 2021 12:57:01 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Philippe Marschall has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 15 commits: >> >> - Merge master >> - Fix bug in CharArrayReader and add unit test >> - Clean up unit tests >> - Revert off-heap code path >> - Replace c-style array declarations >> - Share work buffer between #skip and #read >> - Update copyright year >> - Implement review comment >> - Revert StreamDecoder changes >> - Implement CharArrayReader#read(CharBuffer) >> - ... and 5 more: >> https://git.openjdk.java.net/jdk/compare/d339320e...c4c859e0 > > src/java.base/share/classes/java/io/Reader.java line 205: > >> 203: target.put(cbuf, 0, nread); >> 204: } >> 205: return nread; > > Thanks for bringing this back to just the heap buffer case. This part looks > good now. Agreed. ------------- PR: https://git.openjdk.java.net/jdk/pull/1915
