On Sun, 21 Mar 2021 03:53:24 GMT, Kim Barrett <[email protected]> wrote:

> Please review this change to java.util.Timer, replacing the use of deprecated 
> finalization-based cleanup with use of java.lang.ref.Cleaner.
> 
> In addition, Timer.cancel now cancels any later execution of the the no 
> longer relevant cleanup.
> 
> Testing:
> mach5 tier1
> New AutoStop test verifies the specified cleanup behavior.
> (There are existing tests involving Timer.cancel.)

test/jdk/java/util/Timer/AutoStop.java line 67:

> 65:             t.schedule(new TimerTask() {
> 66:                     public void run() {
> 67:                         ++counter;

This is not thread-safe. Operations on volatile variables are not atomic.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3106

Reply via email to