On Sat, 27 Mar 2021 15:46:36 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Attila Szegedi has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains 13 new >> commits since the last revision: >> >> - Tidy >> - require non null in SimpleBindings >> - Simplify SimpleScriptContext.scopes >> - Mark fields final where possible >> - Deduplicate registerEngineXxx methods >> - Misc tidying >> - Deduplicate exception reporting >> - Lambdify >> - Mark fields as final; eliminate now unnecessary init() method. >> - Deduplicate engine creation and setup code >> - ... and 3 more: >> https://git.openjdk.java.net/jdk/compare/f378f350...56d89eb2 > > src/java.scripting/share/classes/javax/script/ScriptEngineManager.java line > 215: > >> 213: } >> 214: >> 215: private ScriptEngine getEngineBy(String selector, Map<String, >> ScriptEngineFactory> associations, Function<ScriptEngineFactory, >> List<String>> valuesFn) { > > No objection to do some modernization of this code but probably best to avoid > introducing overly long lines as it is impossible to see the changes with > side-by-side diffs. Fair enough, I reformatted lines longer than 120 characters. ------------- PR: https://git.openjdk.java.net/jdk/pull/3229
