On Fri, 2 Apr 2021 21:45:58 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> This test emits to a `java.io.ByteArrayOutputStream` the contents of a > `java.utils.prefs.Preferences` node. The `UTF-8` character encoding is used > [1]. The `ByteArrayOutputStream` is then converted to a `String` using > `toString()` which uses the platform's default character set [2]. The > resulting `String` is then checked for the node names that it should and > should not contain. > > This change proposes to use `ByteArrayOutputStream.toString(String)` to > obtain the string [3] to maintain consistency of the encoding. It also adds > throwing a `RuntimeException` if the node string is not as expected. It is > unclear why this test was not already throwing such an exception. > > [1] > https://docs.oracle.com/en/java/javase/16/docs/api/java.prefs/java/util/prefs/Preferences.html#exportNode(java.io.OutputStream) > [2] > https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString() > [3] > https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/io/ByteArrayOutputStream.html#toString(java.lang.String) Looks good. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3332
