On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick <herr...@openjdk.org> wrote:

>> two changes:
>> One to jpackage, when recursively removing directory, when IOException 
>> occurs, record it and continue (deleting as much as possible) before 
>> throwing the exception.
>> The other to tests, when running jpackage via ProcessBuilder.execute(), set 
>> the "TMP" environment variable to the current value of System Property 
>> "java.io.tmpdir".  This causes the sub-process (jpackage) to output tmp 
>> files to the tmp file location used by the test. (So the test harness can 
>> clean up after test exits).
>
> Andy Herrick has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8265078: jpackage tests on Windows leave large temp files

Although jpackage failing to clean up has only been seen as an issue on 
Windows, allowing it to write outside the test directory (in default tmp dir) 
still exists on mac and linux - I will look into enhancing (what is now 
setWindowsTmpDir()) to be usefull on all platforms.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3473

Reply via email to