On Thu, 15 Apr 2021 12:11:56 GMT, Uwe Schindler <uschind...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move makeXXXSpliterator methods to RandomSupport > > src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line > 1656: > >> 1654: // Methods required by class AbstractSpliteratorGenerator >> 1655: >> 1656: protected Spliterator.OfInt makeIntsSpliterator(long index, >> long fence, int origin, int bound) { > > Are those still needed? It looks like this was not detected because of the > missing `@Override`. Those could also be private or removed at all? The code > is also handled by the above private versions (`this` is not instanceof > `ThreadLocalRandom`). True that. There are also some mentions in the comments. ------------- PR: https://git.openjdk.java.net/jdk/pull/3469