On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon <dnsi...@openjdk.org> wrote:
> I guess this should really be named `isJVMCICompilerEnabled` now and the > `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but maybe > that's too big a change (or can be done later). @dougxc, I don't think that we should (or even can) rename it to `vm.jvmcicompiler.enabled`. although the value of the property is indeed `true` whenever a jvmci compiler is enabled, it is used to filter out tests that are incompatible with a particular compiler -- graal. so what we can do is to change `requires/VMProps.java` to set `vm.graal.enabled` only if the jvmci compiler is indeed graal, but on the other hand, we haven't heard anyone complaining that the test coverage for their jvmci compiler has been reduced, so I don't see much of the benefit here. -- Igor ------------- PR: https://git.openjdk.java.net/jdk/pull/3421
