On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass(). >> The change removes dAC relevant code and changes a lot of tests. Many of >> the changed tests need renaming. I hope to do this in a follow up RFE. >> Some of the tests were modified to use hidden classes, others were deleted >> because either similar hidden classes tests already exist or they tested dAC >> specific functionality, such as host classes. >> >> This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, >> and Mach5 tiers 3-7 on Linux x64. >> >> Thanks, Harold > > Harold Seigel has updated the pull request incrementally with one additional > commit since the last revision: > > test changes and small fixes Hi Harold, Big change! :) This looks good. All the removals of references to unsafe_anonymous were easy enough to follow. I didn't realize that cp patching and psuedo-strings were only related to VM anonymous. It is good to see all that code go as well (but hard to see if you got it all :) ). But as per comment below are we sure psuedo-strings can't be used elsewhere? Thanks, David src/hotspot/share/oops/constantPool.hpp line 493: > 491: // object into a CONSTANT_String entry of an unsafe anonymous class. > 492: // Methods internally created for method handles may also > 493: // use pseudo-strings to link themselves to related metaobjects. Is this comment wrong? Are psuedo-strings not used by anything now? ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3974
