On Thu, 13 May 2021 20:52:33 GMT, Stephen Colebourne <[email protected]>
wrote:
> 8266846: Add java.time.InstantSource
src/java.base/share/classes/java/time/Clock.java line 2:
> 1: /*
> 2: * Copyright (c) 2012, 2019, 2021, Oracle and/or its affiliates. All
> rights reserved.
`2019, ` should be removed.
src/java.base/share/classes/java/time/Clock.java line 115:
> 113: * Where an application only requires the current instant {@code
> InstantSource} should
> 114: * be preferred to this class. For example, his might be the case where
> the time-zone
> 115: * is provided by a separate user localization subsystem.
`@see InstantSource` would be preferred here.
src/java.base/share/classes/java/time/InstantSource.java line 32:
> 30: import java.time.Clock.SystemClock;
> 31: import java.time.Clock.SystemInstantSource;
> 32: import java.time.Clock.TickClock;
Some of them are not used.
src/java.base/share/classes/java/time/InstantSource.java line 112:
> 110: * @return a source that uses the best available system clock, not
> null
> 111: */
> 112: public static InstantSource system() {
`public` is redundant here, same for other methods.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4016
