On Tue, 18 May 2021 22:22:06 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Locale's class description modification > > src/java.base/share/classes/java/util/Locale.java line 462: > >> 460: * backward compatible forms. >> 461: * >> 462: * <p>The APIs added in 1.7 map between the old and new language codes, > > This paragraph needs a rewrite as well it seems, esp. the part that states > "getLanguage and toString reflect the old code" is no longer true. Good catch! In fact, I had modified this paragraph in my preliminary fix, but it slipped away somehow along the fix. Corrected the PR and CSR as well. > test/jdk/java/util/Locale/LocaleTest.java line 683: > >> 681: * @bug 4052404 4778440 8263202 >> 682: */ >> 683: public void TestChangedISO639Codes() { > > Could probably be simplified with a DataProvider. That would be nice, but the test is not testng based, and it would be an entire test rewrite which I would not do it at this time. ------------- PR: https://git.openjdk.java.net/jdk/pull/4069