On 5/24/2021 2:05 AM, Kasper Nielsen wrote:
On Fri, 21 May 2021 02:42:50 GMT, Joe Darcy <da...@openjdk.org> wrote:

Conceptually, AccessbileObject is a sealed class with a protected constructor 
stating

     Constructor: only used by the Java Virtual Machine.

With the language now supporting sealed classes, the AccessbileObject should be 
marked as sealed.

Executable and Field are the subclasses of AccessbileObject in the JDK; as 
Executable has subclasses, it is marked as non-sealed.

Please also review the corresponding CSR:

https://bugs.openjdk.java.net/browse/JDK-8224243
Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

   Update in response to review feedback.
Missed the part about only Executable being made sealed. But if Executable is 
sealed, setAccessible(boolean) could still be moved from Method/Constructor 
down to Executable.

Perhaps; the caller sensitive nature of the methods may preclude or complicate that. I don't plan to add such method hoisting to this PR.

Thanks,

-Joe

Reply via email to