On Thu, 27 May 2021 05:18:50 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Maxim Kartashev has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one new commit since the last revision: >> >> 8195129: System.load() fails to load from unicode paths > > test/hotspot/jtreg/runtime/jni/loadLibraryUnicode/LoadLibraryUnicode.java > line 48: > >> 46: } else { >> 47: throw new Error("Unsupported OS"); >> 48: } > > Please use the test library function `Platform.sharedLibraryExt()` to get the > library file extension. Thanks for the suggestion. Rewrote this piece. (Side note: since the libraries' prefix differs between platforms also, it'd be nice to have something like `Platform.sharedLibraryName(name)`; this is the way all the code that uses `Platform.sharedLibraryExt()` is structured anyway. But I guess it's best not to conflate things). ------------- PR: https://git.openjdk.java.net/jdk/pull/4169