On Thu, 27 May 2021 11:19:24 GMT, Сергей Цыпанов <github.com+10835776+stsypa...@openjdk.org> wrote:
>> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up >> null-checks remaining after >> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as >> Class.getPackageName() never returns null. > > Сергей Цыпанов has updated the pull request incrementally with one additional > commit since the last revision: > > 8265418: Compare package names with == instead of equals() I see this has been integrated but I have concerns that the use-sites now all assume that the package name has been intern'ed. We may some crumbs, maybe in an implNote or comment in the Class::getPackageName code, otherwise we risk breakage if getPackageName changed to return a non-intern'ed string at some point. ------------- PR: https://git.openjdk.java.net/jdk/pull/3571
