On Wed, 2 Jun 2021 06:30:11 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8267706: Break long line in make/ide/idea/jdk/idea.gmk > > The fix was supposed to be just about disentangling cygwin and WSL on Windows > ... not to "improve project setup on all platforms" ... and break project > setup on macOS as a result. If nothing else, if you're changing the set of > required dependencies, this needs to be documented. And installing > `coreutils` seems to bring in a whole lot of unnecessary stuff. @jonathan-gibbons my bad, I should have created another PR for this Regarding documenting changes in dependencies: AFAIK, IDEA project setup is not documented anywhere (at least "IDE support for Java code" section at https://github.com/openjdk/jdk/blob/master/doc/ide.md is WIP). Earlier `idea.sh` required Ant and you wouldn't know about it until it fails at the end of the script :) So could you please clarify, what do you mean by that? ------------- PR: https://git.openjdk.java.net/jdk/pull/4190
