On Wed, 2 Jun 2021 15:00:56 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding as is available from the "native.encoding"
>> system property.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Editorial improvements in outputWriter and inputReader.
We've gone through a few iterations on the javadoc and I think the latest
edition is okay. I don't have time right now for the latest version of the test
(I did look at the test in the initial patch).
src/java.base/share/classes/java/lang/Process.java line 231:
> 229: *
> 230: * <p>The first call to this method creates the {@link
> BufferedReader BufferedReader},
> 231: * if called again with the same {@code charset} the same {@code
> BufferedReader} is returned.
"the same BufferedReader is returned" - a suggestion here to rephrase this to
"then the BufferedReader returned by the first call is returned".
-------------
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4134
