On Wed, 2 Jun 2021 14:50:23 GMT, liach <github.com+7806504+li...@openjdk.org>
wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8268113: Inline local vars where reasonable
>
> src/java.base/share/classes/java/lang/Double.java line 881:
>
>> 879: public static int hashCode(double value) {
>> 880: long bits = doubleToLongBits(value);
>> 881: return Long.hashCode(bits);
>
> Imo these should be squashed to just
>
> return Long.hashCode(doubleToLongBits(value));
>
> since the local variable is no longer meaningful. Previously, they were
> required as they were retrieved twice in hash code calculation.
>
> Same for other usages.
Done!
-------------
PR: https://git.openjdk.java.net/jdk/pull/4309
