On Wed, 2 Jun 2021 15:25:16 GMT, Patrick Concannon <pconcan...@openjdk.org>
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.lang`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Hi Patrick, some minor comments.
src/java.base/share/classes/java/lang/CharacterData.java line 80:
> 78: case 2 -> CharacterData02.instance;
> 79: case 3 -> CharacterData03.instance;
> 80: case 14 -> CharacterData0E.instance; // Private Use
Plane 14 is not `private use`
src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java line 90:
> 88: // findVirtual etc.
> 89: return switch (refKind) {
> 90: case REF_invokeSpecial: {
Is ':' preferred here (and other cases too) instead of "->"?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4312
