On Tue, 8 Jun 2021 17:28:21 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update error message
>
> This all looks reasonable, I just wonder if the --validate description in the 
> help output should provide a brief summary on what it does check. We can add 
> to it as some validation is added. Without it then people will make 
> assumptions on what it does.

@AlanBateman Thanks for the suggestion. I think adding a description is good 
idea. I initially left the description vague, so that the behavior could be 
more easily amended. But, on second thought, such changes would seemingly 
require no less review, so I think it's better to include a description, as 
suggested.

I've updated the description to say the following:


\      --validate             Validate a jar. This process will validate that 
the API\n\
\                             exported by a multi-release jar is consistent 
across all\n\
\                             different release versions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3971

Reply via email to