On Mon, 14 Jun 2021 18:30:23 GMT, Mandy Chung <[email protected]> wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comments
>
> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/LoadLibraryDeadlock.java
> line 44:
>
>> 42: try {
>> 43: // an instance of unsigned class that loads a native
>> library
>> 44: Class c1 = Class.forName("Class1");
>
> nit: `s/Class/Class<?>/ ` avoid raw type (same in line 58)
Changed as suggested.
> test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java line
> 67:
>
>> 65: public Class<?> loadClass(String name) throws
>> ClassNotFoundException {
>> 66: synchronized (getClassLoadingLock(name)) {
>> 67: Class clazz = findLoadedClass(name);
>
> nit: `s/Class/Class<?>/`
Changed as suggested.
> test/jdk/java/lang/ClassLoader/loadLibraryUnload/p/Class1.java line 40:
>
>> 38: System.loadLibrary("loadLibraryUnload");
>> 39: System.out.println("Native library loaded from Class1.");
>> 40: } catch (Exception ignore) {
>
> should this exception just be thrown?
Yep. Removed try-catch.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3976
