On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
> Upstream a critical fix from the panama-foreign repo. > > See the prior review thread here: > https://github.com/openjdk/panama-foreign/pull/558 > > Testing: tier 1-2, local run of run-test-jdk_foreign. Hi Jorn, Seems okay but I have one query below. Thanks, David src/hotspot/share/runtime/frame.inline.hpp line 54: > 52: inline bool frame::is_first_frame() const { > 53: return (is_entry_frame() && entry_frame_is_first()) > 54: || (is_optimized_entry_frame() && optimized_entry_frame_is_first()); Given `optimized_entry_frame_is_first` is only defined on a couple of platforms, it is far from obvious that this call can never happen on the other platforms. A comment explaining this would be useful. ------------- PR: https://git.openjdk.java.net/jdk17/pull/76
