On Mon, 21 Jun 2021 20:21:58 GMT, Andy Herrick <herr...@openjdk.org> wrote:
> …t.java failed "AssertionError: Failed: Check icon"
Changes requested by asemenyuk (Reviewer).
test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 75:
> 73:
> 74: // Create another installer with custom icon.
> 75: long size3 = createInstaller(customIcon, "WithCustom3Icon");
The test should produce WinInstallerIconTest-1.0.exe artifact referenced in SQE
test spec. But this patch will not produce it. It will produce
WinInstallerIconTestWithDefaultIcon-1.0.exe,
WinInstallerIconTestWithCustom2Icon-1.0.exe and
WinInstallerIconTestWithCustom3Icon-1.0.exe artifacts and all of them will be
deleted.
test/jdk/tools/jpackage/windows/WinInstallerIconTest.java line 114:
> 112: size = installerExePath[0].toFile().length();
> 113: TKit.trace(" installer: " + installerExePath[0] + " - size:
> " + size);
> 114: if (nameSuffix != "3") {
Value of `nameSuffix` parameter is never equals to "3"
-------------
PR: https://git.openjdk.java.net/jdk17/pull/111
