On Fri, 25 Jun 2021 16:48:45 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update logging of faults in jdk.serialFilterFactory to log only the
>> exception message
>> Simplify the logging.properties to only the needed settings
>
> test/jdk/java/io/Serializable/serialFilter/SerialFilterFunctionTest.java line
> 49:
>
>> 47: // Enable logging
>> 48: System.setProperty("java.util.logging.config.file",
>> 49: System.getProperty("test.src", ".") +
>> "/logging.properties");
>
> Is `System.setProperty()` needed if it's already being set with -D ?
Fooey; belt and suspenders not needed here.
In some cases, I used the static initializer to avoid adding command line
arguments that would
obscure the command line arguments being tested.
In this case, the log may be interesting for debugging but not integral to the
test correctness.
-------------
PR: https://git.openjdk.java.net/jdk17/pull/85
