On Wed, 12 May 2021 13:12:07 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> But isn't `componentType.descriptorString()` does this itself? Also >> multi-dimensional arrays are quite an infrequent usecase, aren't they? > > Yeah, it's just an optimization. Current code wouldbuild "[[..[[LFoo;" by > recursively going down to `Foo`, build and return "LFoo;", then do "[" + > "LFoo;", and so on. Infrequent enough that we can ignore it, sure, but since > it's effectively reducing the algorithmic complexity from O(n*m) to O(n+m) I > should at least mention it. I see that `TestPrimitiveArrayCriticalWithBadParam` constantly fails, so I'd probably revert this change ------------- PR: https://git.openjdk.java.net/jdk/pull/3627
