Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers

[Alexey Semenyuk]

On Thu, 8 Jul 2021 19:25:33 GMT, Andy Herrick <herr...@openjdk.org> wrote:

> JDK-8269387: jpackage --add-launcher should have option to not create 
> shortcuts for additional launchers

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java 
line 39:

> 37: 
> 38: /*
> 39:  * AddLauncherArguments

Class comment needs to be updated. Currently it says:

 * The add-launcher properties file may have any of:
 *
 * appVersion
 * module
 * main-jar
 * main-class
 * icon
 * arguments
 * java-options
 * win-console
 * linux-app-category

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java 
line 125:

> 123:                 (value == null) ? null : Path.of(value));
> 124: 
> 125:         Arguments.putUnlessNull(bundleParams, SHORTCUT_HINT.getID(),

I think it would be better to add platform-specific options only if jpackage 
runs on that platform:

if (Platform.isWindows())  {
    Arguments.putUnlessNull(bundleParams, SHORTCUT_HINT.getID(), 
getOptionValue(CLIOptions.WIN_SHORTCUT_HINT));
    Arguments.putUnlessNull(bundleParams, MENU_HINT.getID(), 
getOptionValue(CLIOptions.WIN_MENU_HINT));
}

if (Platform.isLinux())  {
    Arguments.putUnlessNull(bundleParams, SHORTCUT_HINT.getID(), 
getOptionValue(CLIOptions.LINUX_SHORTCUT_HINT));
}

-------------

PR: https://git.openjdk.java.net/jdk/pull/4730