On 12/07/21 2:08 am, Lance Andersen wrote:
On Mon, 5 Jul 2021 07:42:26 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
Can I please get a review for this proposed fix for the issue reported in
https://bugs.openjdk.java.net/browse/JDK-8190753?
The commit here checks for the size of the zip entry before trying to create a
`ByteArrayOutputStream` for that entry's content. A new jtreg test has been
included in this commit to reproduce the issue and verify the fix.
P.S: It's still a bit arguable whether it's a good idea to create the
`ByteArrayOutputStream` with an initial size potentially as large as the
`MAX_ARRAY_SIZE` or whether it's better to just use some smaller default value.
However, I think that can be addressed separately while dealing with
https://bugs.openjdk.java.net/browse/JDK-8011146
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
reorganize the tests now that the temp file creation threshold isn't exposed
as a user configurable value
I think the updates made to Zip FS look better. Alan is on vacation so I
would prefer to wait until he gets back and give him a chance to provide any
last thoughts on the change to Zip FS.
The manual test looks OK and is a good addition
Thank you for the reviews and running the tests, Lance. I'll wait for
Alan to be back for his reviews.
-Jaikiran
