On Mon, 9 Aug 2021 18:10:52 GMT, Alan Bateman <al...@openjdk.org> wrote:

> I think I fixed all requested changes. Anymore comments on this PR?

I've looked through the latest revision. Is here any way that we could drop 
most of the changes to ChannelInputStream and focus on one or two specific 
cases? I'm asking because there are several issues, inconsistencies, and it is 
trying to cover many scenarios that aren't covered by the test.

If the original motivation was file -> file then it could be simplified down to 
a FileChannel -> FileChannel transfer as the default provider uses file 
channels.  We could even push some support into FileChannelImpl so that it is 
done while holding the position lock.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4263

Reply via email to