> Please review this change that updates the buildJdkDockerImage() test library > API. > > This work originated while working on "8195809: [TESTBUG] jps and jcmd -l > support for containers is not tested". > The initial intent was to extend the buildJdkDockerImage() API of > DockerTestUtils to accept custom Dockerfile content. > As I analyzed the usage of buildJdkDockerImage() I realized that: > - 2nd argument "dockerfile" is always the same: "Dockerfile-BasicTest" > its use has been obsolete for some time, in favor of Dockerfile > generated by DockerTestUtils > - 3rd argument "buildDirName" is also always the same: "jdk-docker" > > Hence I thought it would be a good idea to simplify this API and make it > up-to-date. > > Also, since the method signature is being updated, I thought it would be a > good idea to also change the name to use more generic container terminology: > buildJdkDockerImage() --> buildJdkContainerImage()
Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision: Addressing review feedback ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/5134/files - new: https://git.openjdk.java.net/jdk/pull/5134/files/51a75339..d211c220 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5134&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5134&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5134.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5134/head:pull/5134 PR: https://git.openjdk.java.net/jdk/pull/5134
