On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung <cche...@openjdk.org> wrote:

>> Please review this change for adding a `jlink` command line option 
>> `--generate-cds-archive` for generating CDS archives as a post processing 
>> step during the creation of a custom JDK image.
>> 
>> Details can be found in the corresponding CSR 
>> [JDK-8269178](https://bugs.openjdk.java.net/browse/JDK-8269178).
>> 
>> Testing:
>> 
>> - [x] tiers 1,2 (including the new test)
>
> Calvin Cheung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   @mlchung comments

This looks okay, and I see a follow-on issue has been created for the test 
improvements.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5174

Reply via email to