On Fri, 3 Sep 2021 13:22:54 GMT, Сергей Цыпанов
<github.com+10835776+stsypa...@openjdk.org> wrote:
> Current implementation looks like this:
>
> public byte[] getBytes(String charsetName)
> throws UnsupportedEncodingException {
> if (charsetName == null) throw new NullPointerException();
> return encode(lookupCharset(charsetName), coder(), value);
> }
>
> Null check seems to be redundant here because the same check of `charsetName`
> is done within `String.lookupCharset(String)`:
>
> private static Charset lookupCharset(String csn) throws
> UnsupportedEncodingException {
> Objects.requireNonNull(csn);
> try {
> return Charset.forName(csn);
> } catch (UnsupportedCharsetException | IllegalCharsetNameException x) {
> throw new UnsupportedEncodingException(csn);
> }
> }
In such cases when the specific exception throwing is removed from the method
because it can be produced by some other used method, the test might be useful.
So if the code in the method will be changed, or the usage of other method will
be removed the exception still be thrown. Probably such test exists already,
then just point to it here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5361
