On 07/09/21 8:35 pm, Roger Riggs wrote:
Hi,
The value of SOURCE_DATE_EPOCH is not so sensitive that it needs the
protections you are applying.
The doPriv only exposes the value of that specific environment
variable and in the usual case, it is undefined.
The complexity in the specification and implementation seem
unnecessary in this case.
Given the inputs so far, the doPriveleged approach appears to be
acceptable. So I'll go ahead and update the PR shortly to change this part.
Though java.util.Date is used in the current implementation, its use
is discouraged in new code
in favor of java.time.ZonedDateTime.
Consider if java.time.format.DateTimeFormatter.RFC_1123_DATE_TIME can
be used to parse and format the time.
Noted. I'll take a look at these and update the PR as necessary.
Thank you all for the inputs so far.
-Jaikiran
