On Wed, 22 Sep 2021 17:41:18 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> The Mac OS specific code to determine the os.version property in >> java_props_macosx.c is updated >> to replace the code extracting the version from the SystemVersion.plist by >> reading the version using t\ >> he hidden link: > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Check for missing version from SystemVersion plist. > Refactor avoid repetition of conversion of NSString to char *. Looks good to me. I tested with an Xcode 11.7 build on a MacOS 11.6 and there OsVersionTest fails without the fix and passes with it. ------------- Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5633
