On Tue, 19 Oct 2021 14:22:26 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Can I please get a review for this change which addresses 
>> https://bugs.openjdk.java.net/browse/JDK-8269336?
>> 
>> As noted in that issue, this change will now propagate any exception that 
>> occurred during parsing and creation of the filter configured through the 
>> `jdk.serialFilter` system property. It will also continue to log those 
>> errors, like it previously did.
>> 
>> A new jtreg test has been introduced to reproduce this issue and verify the 
>> fix. 
>> 
>> Given that invalid values for this system property will now start throwing 
>> exception, will this change need a CSR?
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Roger's review suggestion - rethrow the RuntimeException instead of 
> wrapping in ExceptionInInitializerError

Thank you Roger for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5988

Reply via email to