On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>>> How you verified correctness of results? I suggest to extend >>> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned >>> method. >> >> Tests for unsignedMultiplyHigh were already added in >> test/jdk//java/lang/Math/MultiplicationTests.java (in July 2021 by Brian >> Burkhalter). Used that test to verify the correctness of the results. > >> > How you verified correctness of results? I suggest to extend >> > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned >> > method. >> >> Tests for unsignedMultiplyHigh were already added in >> test/jdk//java/lang/Math/MultiplicationTests.java (in July 2021 by Brian >> Burkhalter). Used that test to verify the correctness of the results. > > Good. It seems I have old version of the test. > Did you run it with -Xcomp? How you verified that intrinsic is used? @vnkozlov if the patch looks ok to you, could you please run this through your testing? ------------- PR: https://git.openjdk.java.net/jdk/pull/5933
