On Wed, 3 Nov 2021 14:24:28 GMT, Stephen Colebourne <scolebou...@openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test verifying OOB values throw exception > > Thanks for adding the new tests, and finding that fraction formatting is more > constrained than I thought it was. > > I think there is a case for a spec update in `DateTimeFormatterBuilder` to > clarify the constraint on the input value (at this point, that seems better > than changing the behaviour of fraction formatting). As things stand, the > exception that is thrown is not described by the spec. (The spec change could > be part of this PR or a separate one). Thanks for reviewing, @jodastephen! I think a spec update sounds good, but I think that should be done in as a follow-up. If you would be willing to provide the wording for such a spec update I can take care of creating a CSR. ------------- PR: https://git.openjdk.java.net/jdk/pull/6188
