On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
> This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducibility: > - Jar and ZipOutputStream are not SOURCE_DATE_EPOCH aware > - Jar and ZipOutputStream now detect SOURCE_DATE_EPOCH environment setting > - Jar and Jmod file content ordering was non-determinsitic > - Fixes to Jar and Jmod main's to ensure sorted classes content ordering > - openjdk image zip file generation used "zip" which is non-determinsitic > - New openjdk build tool "GenerateZip" which produces the final > determinsitic zip files as part of the build and also detects > SOURCE_DATE_EPOCH > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> Thanks Magnus, You've just reminded me of why I gave up trying to write my own zip, I achieved it, but realized it was slow damn slow, and how efficient and optimized the off the shelf zip is...! Hence, why I let zip still do it's inclusion/exclusion job it does so well, and then just re-generate at the end. Takes about 2-3 seconds longer, so not an issue really. cheers ------------- PR: https://git.openjdk.java.net/jdk/pull/6268
