On Wed, 17 Nov 2021 20:13:03 GMT, Lance Andersen <[email protected]> wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 828:
>>
>>> 826: String[] dirFiles = f.list();
>>> 827: // Ensure files list is sorted for reproducible
>>> jar content
>>> 828: if (dirFiles != null)
>>
>> Style issue. I strongly dislike multi-line if statements without braces. I
>> don't know if that style is followed in the rest of the code, but if it
>> seems to fit in I strongly recommend using braces.
>
> I agree, we should change this to include braces with the if statement.
I agree, I always use {}, I was being consistent with the rest of the expand()
method, but I will add {} as I prefer that too, better to set a good example!
-------------
PR: https://git.openjdk.java.net/jdk/pull/6395
