On Fri, 19 Nov 2021 20:13:06 GMT, Stuart Marks <sma...@openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove Finalizer.Holder class.
>
> Regarding **jcmd** updates, I'm thinking maybe this would be better handled 
> separately. There is the potential to update to `GC.finalizer_info` discussed 
> previously. Looking at the **jcmd** tool docs, it seems like 
> `GC.run_finalization` also ought to be updated. And maybe one or more of the 
> other commands (maybe `VM.flags` or `VM.info`?) ought to list the 
> finalization enabled or disabled status. And of course the tool's doc will 
> need to be updated as well.

@stuart-marks no issue with doing dcmd/jcmd changes separately, but I don't 
think we need to go too far with this. I had considered `GC.run_finalization` 
but it just says it calls `System.run_finalization` - so no change needed there 
as it will be documented in System.runFinalization. And `VM.flags` only reports 
`-XX` flag information. And `VM.info` doesn't seem appropriate for mentioning 
this either. So no further changes needed to the other Dcmds IMO and no need to 
update anything on the jcmd tool page either.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6442

Reply via email to