On Thu, 25 Nov 2021 09:37:59 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> test/jdk/tools/jar/JarEntryTime.java line 129: >> >>> 127: // Make a jar file from that directory structure with >>> 128: // --source-date set to epoch seconds 1647302400 (15/03/2022) >>> 129: long sourceDate = 1647302400L; >> >> Please consider adding a few before Epoch test values. > > @LanceAndersen can you clarify your meaning here please? Are you referring to > negative sourceDate? I put in the CSR that it was seconds "since" epoch akin > to SOURCE_DATE_EPOCH, which as far as I can tell does not support negative > values, as some time implementations won't support that. > But this does imply I should add some -ve validation checks. I think we could support -ve values, though i'd need to alter a couple of things ------------- PR: https://git.openjdk.java.net/jdk/pull/6481
