On Wed, 1 Dec 2021 19:59:57 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Before signing, unsign all executables and libraries (not just those in >> runtime). >> Also, run individual file sign and unsign commands in quiet mode. >> Also, add test case to SigningAppImageTest to test that signing app that has >> additional launcher works, and results in validly signed launcher and >> additional launcher (original reported problem). > > test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 95: > >> 93: SigningBase.verifyCodesign(launcherPath, true); >> 94: SigningBase.verifyCodesign(testALPath, true); >> 95: } > > Would it make sense to extend the existing test with additional launcher > checks instead of creating another one? Packaging of a full JDK with signing > probably takes a while yes - that would be simpler - will do. ------------- PR: https://git.openjdk.java.net/jdk/pull/6636
