On Tue, 25 Jan 2022 00:20:19 GMT, Yumin Qi <mi...@openjdk.org> wrote:
> Please review, > When jlink with --compress=2, zip is used to compress the files while doing > copy. The user case failed to load zip.dll, since zip.dll is not set in PATH. > This failure is after we get NULL from GetModuleHandle("zip.dll"), then do > LoadLibrary("zip.dll") will have same result. > The fix is calling load_zip_library of ClassLoader first --- if zip library > already loaded just return the cached handle for following usage, if not, > load zip library and cached the handle. > > Tests: tier1,4,7 in test > Manually tested user case, and checked output of jimage list <modules> for > jlinked files using --compress=2. > > Thanks > Yumin This pull request has now been integrated. Changeset: cda9c301 Author: Yumin Qi <mi...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/cda9c3011beeec8df68e78e096132e712255ce1b Stats: 49 lines in 6 files changed: 18 ins; 14 del; 17 mod 8278753: Runtime crashes with access violation during JNI_CreateJavaVM call Reviewed-by: dholmes, stuefe ------------- PR: https://git.openjdk.java.net/jdk/pull/7206